IGNITE-24239 Create a reproducer for IGNITE-23588 #5065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ibessonov <[email protected]>
Signed-off-by: ibessonov <[email protected]>
Signed-off-by: ibessonov <[email protected]>
Phillippko
reviewed
Jan 20, 2025
...Test/java/org/apache/ignite/internal/pagememory/tree/util/SequencedOffheapReadWriteLock.java
Outdated
Show resolved
Hide resolved
...Test/java/org/apache/ignite/internal/pagememory/tree/util/SequencedOffheapReadWriteLock.java
Outdated
Show resolved
Hide resolved
| * Constructor. | ||
| */ | ||
| public SequencedOffheapReadWriteLock() { | ||
| super(128); |
There was a problem hiding this comment.
I noticed that Persistent regions use hard-coded 128, though volatile memory uses system property. Is it intented? Could we make a constructor with this logic? So we don't pass magic "128" everywhere. Or we could make a TestOnly constructor without args using 128
/** Concurrency level. */
private final int lockConcLvl = IgniteSystemProperties.getInteger(
IGNITE_OFFHEAP_LOCK_CONCURRENCY_LEVEL,
Integer.highestOneBit(Runtime.getRuntime().availableProcessors() * 4)
);
There was a problem hiding this comment.
Not in this PR :)
...mory/src/integrationTest/java/org/apache/ignite/internal/pagememory/tree/util/Sequencer.java
Outdated
Show resolved
Hide resolved
Signed-off-by: ibessonov <[email protected]>
Signed-off-by: ibessonov <[email protected]>
Signed-off-by: ibessonov <[email protected]>
Signed-off-by: ibessonov <[email protected]>
Signed-off-by: ibessonov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-24239
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
The Review Checklist
- There is a single JIRA ticket related to the pull request.
- The web-link to the pull request is attached to the JIRA ticket.
- The JIRA ticket has the Patch Available state.
- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
Notes